test: update test_util.cc for coverage #55291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test_util.cc for code coverage src/util-inl.h:PopFront()
nodejs-github-bot
added
needs-ci
|
Why is this change important? IIRC the coverage of individual CPP functions isn't important, right? |
RedYetiDev
added
the
c++
anonrig
approved these changes
Oct 7, 2024
RedYetiDev
added
author ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55291 +/- ##
=======================================
Coverage 88.41% 88.42%
=======================================
Files 652 652
Lines 186612 186612
Branches 36062 36058 -4
=======================================
+ Hits 165001 165006 +5
+ Misses 14885 14880 -5
Partials 6726 6726 |
github-actions
bot
removed
the
request-ci
Thank you for the comment! As you mentioned, I also think the coverage of individual cpp function is not important. |
lpinca
approved these changes
Oct 12, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b579779 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Oct 14, 2024
update test_util.cc for code coverage src/util-inl.h:PopFront() PR-URL: nodejs#55291 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: update test_util.cc for code coverage
target file
target function
AS-IS
TO-BE